[2.x] fix: Fix ProjectMatrix invalid project ID with CrossVersion.full#8484
Merged
eed3si9n merged 2 commits intosbt:developfrom Jan 12, 2026
Merged
Conversation
Contributor
Author
|
I've just signed CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8458
When using
ProjectMatrixwithCrossVersion.fulland Scala 2 versions like2.13.18, the project ID incorrectly became$1$2_13_18instead offoo2_13_18.Root cause: The Scala 3 compiler creates synthetic intermediate vals (e.g.,
$1) during macro expansion. TheenclosingTermfunction in the macros was stopping at these synthetic symbols instead of continuing up the symbol tree to find the actual val name.Fix: Added
Flags.Syntheticcheck to skip compiler-generated symbols in:main-settings/src/main/scala/sbt/std/KeyMacro.scalalm-core/src/main/scala/sbt/librarymanagement/ConfigurationExtra.scalaTest
Before: sbt projects shows $1$2_13_18, $1$3_3_7
After: sbt projects shows foo2_13_18, foo3_3_7
Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=4217675