Skip to content

[2.x] Report eviction errors for Test dependencies#8451

Merged
eed3si9n merged 3 commits intosbt:developfrom
calm329:fix/8410-test-eviction-errors
Jan 9, 2026
Merged

[2.x] Report eviction errors for Test dependencies#8451
eed3si9n merged 3 commits intosbt:developfrom
calm329:fix/8410-test-eviction-errors

Conversation

@calm329
Copy link
Copy Markdown
Contributor

@calm329 calm329 commented Jan 8, 2026

Eviction warnings and errors were not reported for Test dependencies because
EvictionError only checked the Compile configuration.

This fix runs the eviction check for both Compile and Test configurations
separately, with distinct error messages:

  • Compile: found version conflict(s) in library dependencies
  • Test: found version conflict(s) in Test dependencies

Fixes #8410


Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=148254234

Copy link
Copy Markdown
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks for adding the scripted test.

@calm329
Copy link
Copy Markdown
Contributor Author

calm329 commented Jan 8, 2026

Overall LGTM. Thanks for adding the scripted test.

Thanks for approving, I'm glad to contribute!

@calm329
Copy link
Copy Markdown
Contributor Author

calm329 commented Jan 8, 2026

I signed the CLA.

@calm329
Copy link
Copy Markdown
Contributor Author

calm329 commented Jan 8, 2026

@eed3si9n Could you please approve the workflow run? The first run failed on the MiMa check, so I pushed a follow-up commit to add the necessary binary compatibility filter. I've signed the Scala CLA as well.

@calm329
Copy link
Copy Markdown
Contributor Author

calm329 commented Jan 8, 2026

@eed3si9n I'm sorry, there were some issues and I've pushed the fixes. Could you approve the workflows again?

@calm329
Copy link
Copy Markdown
Contributor Author

calm329 commented Jan 8, 2026

All checks have been passed!

@eed3si9n eed3si9n merged commit 8c20401 into sbt:develop Jan 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report eviction errors for Test dependencies

2 participants