[2.x] Fix --sbt-version to expand to -Dsbt.version#8446
[2.x] Fix --sbt-version to expand to -Dsbt.version#8446eed3si9n merged 2 commits intosbt:developfrom
Conversation
|
The change lgtm. Could you sign the CLA and let me know plz? |
|
@eed3si9n |
|
Let me know if you get a response from the email then. Currenlty CLA check is failing. |
eed3si9n
changed the title
Fixes sbt#6645 The --sbt-version flag was incorrectly trying to download an sbt launcher with the specified version, which doesn't exist for many sbt versions. Changes: - Modified --sbt-version handling to directly add -Dsbt.version property - Removed sbt_version variable assignment that caused launcher mismatch - acquire_sbt_jar now uses default launcher version instead Now --sbt-version X.Y.Z correctly expands to -Dsbt.version=X.Y.Z without affecting the sbt launcher version used to run the build.
Achieve3318
force-pushed
the
fix-sbt-version-flag
branch
from
3755f86 to
a0f5c83
Compare
|
@eed3si9n
Both give: "The redirect_uri is not associated with this application" Could you please:
I'm happy to sign however needed. Thanks! |
|
As far as I know, it should be https://contribute.akka.io/contribute/cla/scala/sign. |
|
please check again. Thanks |
2 participants
Fixes #6645
The --sbt-version flag was incorrectly trying to download an sbt launcher with the specified version, which doesn't exist for many sbt versions.
Changes:
Now --sbt-version X.Y.Z correctly expands to -Dsbt.version=X.Y.Z without affecting the sbt launcher version used to run the build.