Skip to content

[2.x] fix: prevent server boot when --no-server is used#8444

Merged
eed3si9n merged 3 commits intosbt:developfrom
James-4u:fix-no-server-boot-socket
Jan 7, 2026
Merged

[2.x] fix: prevent server boot when --no-server is used#8444
eed3si9n merged 3 commits intosbt:developfrom
James-4u:fix-no-server-boot-socket

Conversation

@James-4u
Copy link
Copy Markdown
Contributor

@James-4u James-4u commented Jan 7, 2026

Fix --no-server flag not preventing boot server socket creation

Check sbt.server.autostart property before creating BootServerSocket.
When --no-server is used, it sets sbt.server.autostart=false, but
Main.scala was still attempting to create the boot server socket
based only on isServer check.

This caused ServerAlreadyBootingException on Windows when multiple
sbt instances tried to create the same named pipe simultaneously.

Fixes #8177

Contribution by Gittensor, see my contribution statistics at https://gittensor.io/miners/details?githubId=102175066

@James-4u
Copy link
Copy Markdown
Contributor Author

James-4u commented Jan 7, 2026

@durban @eed3si9n could you please review my pr?

@James-4u James-4u requested a review from eed3si9n January 7, 2026 12:49
Copy link
Copy Markdown
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@James-4u James-4u requested a review from eed3si9n January 7, 2026 17:08
@eed3si9n eed3si9n merged commit a4ad73d into sbt:develop Jan 7, 2026
14 checks passed
@eed3si9n eed3si9n changed the title fix: prevent server boot when --no-server is used [2.x] fix: prevent server boot when --no-server is used Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--no-server doesn't seem to work

2 participants