Skip to content

ScriptedRun bincompat issues #8653

@eed3si9n

Description

@eed3si9n

problem

In #8621 I okayed adding mimaBinaryIssueFilters for

      exclude[DirectMissingMethodProblem]("sbt.ScriptedRun.run"),
      exclude[DirectMissingMethodProblem]("sbt.ScriptedRun.invoke"),
      exclude[ReversedMissingMethodProblem]("sbt.ScriptedRun.invoke"),
      exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunInParallelV1.invoke"),
      exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunInParallelV2.invoke"),
      exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunV1.invoke"),
      exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunV2.invoke"),

but now I think that was a mistake, since we have to keep bincompat so sbt 1.x can still call sbt 2.x for cross building (that is building sbt 2.x plugin using sbt 1.x).

expectation

Remove the mimaBinaryIssueFilters by restoring the old method signatures for backward compatibility.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions