-
Notifications
You must be signed in to change notification settings - Fork 1k
ScriptedRun bincompat issues #8653
Copy link
Copy link
Closed
Labels
Description
problem
In #8621 I okayed adding mimaBinaryIssueFilters for
exclude[DirectMissingMethodProblem]("sbt.ScriptedRun.run"),
exclude[DirectMissingMethodProblem]("sbt.ScriptedRun.invoke"),
exclude[ReversedMissingMethodProblem]("sbt.ScriptedRun.invoke"),
exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunInParallelV1.invoke"),
exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunInParallelV2.invoke"),
exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunV1.invoke"),
exclude[DirectMissingMethodProblem]("sbt.ScriptedRun#RunV2.invoke"),but now I think that was a mistake, since we have to keep bincompat so sbt 1.x can still call sbt 2.x for cross building (that is building sbt 2.x plugin using sbt 1.x).
expectation
Remove the mimaBinaryIssueFilters by restoring the old method signatures for backward compatibility.
Reactions are currently unavailable