Skip to content

Changing order of fingerprints to allow tests with @RunWith to execute#37

Merged
jsuereth merged 1 commit intosbt:masterfrom
wolfgangmeyers:runwithit
Jan 9, 2014
Merged

Changing order of fingerprints to allow tests with @RunWith to execute#37
jsuereth merged 1 commit intosbt:masterfrom
wolfgangmeyers:runwithit

Conversation

@wolfgangmeyers
Copy link
Copy Markdown

I found that when tests that were annotated with @RunWith(SpringJUnit4ClassRunner.class) did not get properly executed when using junit-interface (sbt 0.13). After some digging, it appeared that it was because these test definitions were being assigned the JunitFingerprint, when they should have been assigned the RunWithFingerprint. My guess was that the first matching fingerprint for each test definition was used, so it made sense that making RunWithFingerprint the first item returned from the framework would cause RunWithFingerprint to be assigned to test definitions having the @RunWith annotation - after switching to the forked version with the new ordering, my tests now execute using the Junit Runner as expected.

@benmccann
Copy link
Copy Markdown
Contributor

Open issue for this bug with reproduction steps: #14 (comment)

@benmccann
Copy link
Copy Markdown
Contributor

See also the comment by @retronym on another open bug #21 (comment)

@wolfgangmeyers
Copy link
Copy Markdown
Author

Looks to me like this is the same problem as #21

@jsuereth
Copy link
Copy Markdown
Member

jsuereth commented Jan 9, 2014

Nice analysis and fix! Thanks much.

jsuereth added a commit that referenced this pull request Jan 9, 2014
Changing order of fingerprints to allow tests with @RunWith to execute
@jsuereth jsuereth merged commit 261a761 into sbt:master Jan 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants