Changing order of fingerprints to allow tests with @RunWith to execute#37
Merged
jsuereth merged 1 commit intosbt:masterfrom Jan 9, 2014
Merged
Changing order of fingerprints to allow tests with @RunWith to execute#37jsuereth merged 1 commit intosbt:masterfrom
jsuereth merged 1 commit intosbt:masterfrom
Conversation
Contributor
|
Open issue for this bug with reproduction steps: #14 (comment) |
Contributor
|
See also the comment by @retronym on another open bug #21 (comment) |
Author
|
Looks to me like this is the same problem as #21 |
Member
|
Nice analysis and fix! Thanks much. |
jsuereth
added a commit
that referenced
this pull request
Jan 9, 2014
Changing order of fingerprints to allow tests with @RunWith to execute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that when tests that were annotated with @RunWith(SpringJUnit4ClassRunner.class) did not get properly executed when using junit-interface (sbt 0.13). After some digging, it appeared that it was because these test definitions were being assigned the JunitFingerprint, when they should have been assigned the RunWithFingerprint. My guess was that the first matching fingerprint for each test definition was used, so it made sense that making RunWithFingerprint the first item returned from the framework would cause RunWithFingerprint to be assigned to test definitions having the @RunWith annotation - after switching to the forked version with the new ordering, my tests now execute using the Junit Runner as expected.