WRONG_INDENTATION: add more tests for extendedIndentAfterOperators#1401
Merged
0x6675636b796f75676974687562 merged 3 commits intomasterfrom Jun 27, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1401 +/- ##
============================================
+ Coverage 83.39% 83.40% +0.01%
Complexity 2538 2538
============================================
Files 106 106
Lines 7623 7623
Branches 2089 2089
============================================
+ Hits 6357 6358 +1
Misses 375 375
+ Partials 891 890 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Contributor
orchestr7
reviewed
Jun 25, 2022
orchestr7
approved these changes
Jun 25, 2022
Member
orchestr7
left a comment
orchestr7
left a comment
There was a problem hiding this comment.
lgtm, but please remove at least some complexity with annotations
### What's done: * Tests for expressions wrapped on an operator have been added. * Both cases (when `extendedIndentAfterOperators` is `true` and `false`) are tested. * Both binary operators and functions are tested. * Related: #1340
### What's done: * Test resources extracted into a separate class so that DeteKT remains quiet. * Reformatted test code so that DiKTat remains quiet.
### What's done: * Code cleaned up.
0x6675636b796f75676974687562
force-pushed
the
feature/andrey.shcheglov/indentation-unit-tests
branch
from
9e8527f to
8276dcf
Compare
0x6675636b796f75676974687562
deleted the
feature/andrey.shcheglov/indentation-unit-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done:
extendedIndentAfterOperatorsistrueandfalse) are tested.WRONG_INDENTATION:extendedIndentAfterOperatorsignored if lines are wrapped before a binary operator or an infix function #1340.Actions checklist