Add Linux dark mode detection for Fusion theme in Qt6 #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Great Job! FLOG_X() are okay. but LOG_X() are more convenient, and you won't need take care about types. Anyway, I will take care about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Eric - I noticed a comment from 2024 about dark mode in the AppImage, so I added a quick fix for the QT6 version when the theme is set to
fusion. This should align the behavior to what you expect. Thanks for the awesome tool. 🥇Here is a screenshot of the AppImage compiled with the patch, from the latest version of your repo, running on Linux Mint v22, Gnome 48.
And then here is a screenshot with Gnome switched to a light mode theme and the .AppImnage closed and re-opened.