-
Notifications
You must be signed in to change notification settings - Fork 10
feat: display cd guidance after hooks execution #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display cd guidance after hooks execution #48
Conversation
Display the 'wtp cd' guidance message after executing post-create hooks instead of before. This improves UX when hooks take time to execute, as users can immediately see the navigation command without scrolling up. Closes satococoa#46 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
WalkthroughThe success message for worktree creation has been reordered to display after post-creation hooks execute, rather than before. Hook execution and error handling remain unchanged; only the timing of the success message display has shifted. Changes
Sequence DiagramsequenceDiagram
participant User
participant add.go
participant Hooks
rect rgb(200, 220, 240)
Note over add.go: Previous Flow
add.go->>User: Display success message
add.go->>Hooks: Execute post-create hooks
Hooks->>Hooks: Run (may take time)
end
rect rgb(220, 240, 220)
Note over add.go: New Flow
add.go->>Hooks: Execute post-create hooks
Hooks->>Hooks: Run (may take time)
add.go->>User: Display success message
end
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @satococoa, I'd really appreciate it if you could review it! |
satococoa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
I'll merge this 👍 😄
Summary
wtp cdguidance message after executing post-create hooks instead of beforeChanges
addCommandWithCommandExecutorto show hooks execution first, then success messageBenefits
Testing
Closes #46
🤖 Generated with Claude Code
Summary by CodeRabbit