Skip to content

Restore noctx lint coverage #51

@satococoa

Description

@satococoa

Summary

During the golangci-lint v2 migration we dropped the noctx linter. Without it, new exec.Command usages can be added without a context or timeout, which was previously caught by lint.

Desired outcome

  • Re-enable noctx in .golangci.yml.
  • Update the codebase to call exec.CommandContext (or provide context-aware wrappers) for all external command executions.
  • Ensure the linter passes without suppressing noctx globally.

Notes

  • The git helpers in internal/git already centralize most command execution, so adding contexts there should cover the majority of cases.
  • For CLI commands, a background context (or user-supplied timeout) is acceptable when no better signal exists.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions