-
Notifications
You must be signed in to change notification settings - Fork 10
Closed
Description
Summary
During the golangci-lint v2 migration we dropped the noctx linter. Without it, new exec.Command usages can be added without a context or timeout, which was previously caught by lint.
Desired outcome
- Re-enable
noctxin.golangci.yml. - Update the codebase to call
exec.CommandContext(or provide context-aware wrappers) for all external command executions. - Ensure the linter passes without suppressing
noctxglobally.
Notes
- The git helpers in
internal/gitalready centralize most command execution, so adding contexts there should cover the majority of cases. - For CLI commands, a background context (or user-supplied timeout) is acceptable when no better signal exists.
Metadata
Metadata
Assignees
Labels
No labels