Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Fix compile issue on Mac OS X - #174

Merged
bolandrm merged 1 commit into
sass:masterfrom
dtynan:fix_for_macos
Dec 2, 2019
Merged

Fix compile issue on Mac OS X#174
bolandrm merged 1 commit into
sass:masterfrom
dtynan:fix_for_macos

Conversation

@dtynan

@dtynan dtynan commented Nov 28, 2019

Copy link
Copy Markdown
Contributor

Gem won't install on Mac OS X (Mohave) due to a compile error:

libsass.bundle malformed object (unknown load command 7)

This is in the code line which strips libsass.bundle of symbols. So this "fix" removes that command. I'm sure there's a better way, but this fixed the problem for me. Not sure why the bundle needs to be stripped or why Mac OS X has an issue with it.h

@bolandrm

bolandrm commented Dec 2, 2019

Copy link
Copy Markdown
Member

@glebm does this seem ok to you?

@glebm

glebm commented Dec 2, 2019

Copy link
Copy Markdown
Contributor

Yes. strip is nice for precompiled gems, but we no longer ship those for most platforms.

@bolandrm
bolandrm merged commit 7cbb577 into sass:master Dec 2, 2019
@ahorek ahorek mentioned this pull request Feb 18, 2020
@ahorek

ahorek commented Feb 18, 2020

Copy link
Copy Markdown

I would like to make this optional because it'll increase the binary size on all other platforms for no reason, here's my proposal #184

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 17, 2020
Update to ruby-sassc to 2.3.0.


- **2.3.0**
  - [Fix rake gem:native task](sass/sassc-ruby#196)
  - [disable lto flag for darwin + nix](sass/sassc-ruby#166)
  - [Sort input file list](sass/sassc-ruby#178)
  - [Set appropriate encoding for source_map](sass/sassc-ruby#152)
  - [allow passing functions directly](sass/sassc-ruby#162)
  - [always dispose data context](sass/sassc-ruby#161)
  - [Update libsass to 3.6.3](sass/sassc-ruby#164)
  - [Restore strip symbols](sass/sassc-ruby#184)
  - [Default --march-tune-native to false](sass/sassc-ruby#158)
  - [Fix compile issue on Mac OS X](sass/sassc-ruby#174)
  - [Test on TruffleRuby in TravisCI](sass/sassc-ruby#171)
  - [Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions](sass/sassc-ruby#173)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants