Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

disable lto flag for darwin + nix - #166

Merged
bolandrm merged 1 commit into
sass:masterfrom
michaelglass:patch-1
Mar 4, 2020
Merged

disable lto flag for darwin + nix#166
bolandrm merged 1 commit into
sass:masterfrom
michaelglass:patch-1

Conversation

@michaelglass

Copy link
Copy Markdown
Contributor

darwin nix's clang doesn't support -lto

this PR disables -lto flag for darwin + nix

see #148 for more context

@lrworth

lrworth commented Dec 5, 2019

Copy link
Copy Markdown

It'd be awesome if this got merged, just saying.

@lavoiesl

lavoiesl commented Dec 5, 2019

Copy link
Copy Markdown

I’m also experiencing this problem.

Better lto detection would be great, but this is a non-intrusive fix and would unblock other people.

@bolandrm

bolandrm commented Mar 3, 2020

Copy link
Copy Markdown
Member

@glebm could you please review this PR?

@bolandrm
bolandrm merged commit 275fe38 into sass:master Mar 4, 2020
@michaelglass
michaelglass deleted the patch-1 branch March 4, 2020 16:28
@lrworth

lrworth commented May 12, 2020

Copy link
Copy Markdown

I haven't tested this version - does it work? #192 makes more sense to me.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 17, 2020
Update to ruby-sassc to 2.3.0.


- **2.3.0**
  - [Fix rake gem:native task](sass/sassc-ruby#196)
  - [disable lto flag for darwin + nix](sass/sassc-ruby#166)
  - [Sort input file list](sass/sassc-ruby#178)
  - [Set appropriate encoding for source_map](sass/sassc-ruby#152)
  - [allow passing functions directly](sass/sassc-ruby#162)
  - [always dispose data context](sass/sassc-ruby#161)
  - [Update libsass to 3.6.3](sass/sassc-ruby#164)
  - [Restore strip symbols](sass/sassc-ruby#184)
  - [Default --march-tune-native to false](sass/sassc-ruby#158)
  - [Fix compile issue on Mac OS X](sass/sassc-ruby#174)
  - [Test on TruffleRuby in TravisCI](sass/sassc-ruby#171)
  - [Use RbConfig::MAKEFILE_CONFIG['DLEXT'] instead of hardcoding extensions](sass/sassc-ruby#173)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants