Skip to content

Commit c3df197

Browse files
fix(muse): refresh advanced child approvals after decision failure
1 parent d8a6848 commit c3df197

2 files changed

Lines changed: 63 additions & 0 deletions

File tree

‎packages/provider-muse/src/server/adapter.test.ts‎

Lines changed: 55 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,6 +1202,61 @@ describe("MuseAdapterV2", () => {
12021202
}).pipe(Effect.scoped, Effect.provide(testLayer)),
12031203
);
12041204

1205+
it.effect("refreshes an absorbed child approval stage after its automatic decision fails", () =>
1206+
Effect.gen(function* () {
1207+
const fake = yield* makeFakeMuse();
1208+
const harness = yield* makeHarness(fake);
1209+
const { nativeId } = yield* startConversation(harness, fake);
1210+
const acknowledgement = pendingPromise<Record<string, unknown>>();
1211+
fake.queueResponse("approval/decide", acknowledgement.promise);
1212+
const childApproval = { ...approval("child-run-1"), subagentOrigin: { subagentId: "a7" } };
1213+
yield* fake.emit("approval/requested", childApproval);
1214+
const first = (yield* harness.takeEvent("runtime_request.updated")).runtimeRequest;
1215+
yield* fake.takeCall("approval/decide");
1216+
const nextStage = {
1217+
...childApproval,
1218+
currentRequirementId: { approvalId: "approval-1", sourceIndex: 1 },
1219+
subject: { kind: "shell", command: "touch next-stage.txt" },
1220+
change: { kind: "stageResolved" },
1221+
};
1222+
yield* fake.emit("approval/updated", nextStage);
1223+
yield* fake.emit("item/completed", {
1224+
turnId: nativeId,
1225+
item: {
1226+
itemId: "frontier-ingested",
1227+
turnId: nativeId,
1228+
kind: "agentMessage",
1229+
revision: 1,
1230+
status: "completed",
1231+
text: "frontier ingested",
1232+
},
1233+
});
1234+
yield* harness.takeEvent(
1235+
"message.updated",
1236+
(event) => event.message.text === "frontier ingested",
1237+
);
1238+
acknowledgement.reject(new Error("Decision acknowledgement failed"));
1239+
const refreshed = (yield* harness.takeEvent("runtime_request.updated")).runtimeRequest;
1240+
assert.strictEqual(refreshed.id, first.id);
1241+
assert.strictEqual(refreshed.status, "pending");
1242+
const card = yield* harness.takeEvent(
1243+
"turn_item.updated",
1244+
(event) =>
1245+
event.turnItem.type === "approval_request" &&
1246+
event.turnItem.prompt === nextStage.subject.command,
1247+
);
1248+
assert.strictEqual(card.turnItem.nodeId, first.nodeId);
1249+
const nextDecision = yield* fake.takeCall("approval/decide");
1250+
assert.deepStrictEqual(nextDecision.params.requirementId, nextStage.currentRequirementId);
1251+
assert.strictEqual(nextDecision.params.choiceId, "once");
1252+
yield* fake.emit("approval/resolved", nextStage);
1253+
yield* harness.takeEvent(
1254+
"runtime_request.updated",
1255+
(event) => event.runtimeRequest.status === "resolved",
1256+
);
1257+
}).pipe(Effect.scoped, Effect.provide(testLayer)),
1258+
);
1259+
12051260
it.effect("keeps a workflow child's approval pending for the user past the turn's end", () =>
12061261
Effect.gen(function* () {
12071262
const fake = yield* makeFakeMuse();

‎packages/provider-muse/src/server/adapter.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1102,6 +1102,14 @@ export const makeMuseAdapterV2 = Effect.fn("makeMuseAdapterV2")(function* (
11021102
roundTrip.terminal ||= exit._tag === "Success" && exit.value.terminal === true;
11031103
if (exit._tag === "Failure" && owner === "adapter" && !roundTrip.terminal) {
11041104
delete entry.response;
1105+
if (
1106+
entry.native.type === "approval" &&
1107+
(entry.native.value.currentRequirementId.approvalId !==
1108+
roundTrip.requirementId.approvalId ||
1109+
entry.native.value.currentRequirementId.sourceIndex !==
1110+
roundTrip.requirementId.sourceIndex)
1111+
)
1112+
yield* publishRequest(entry.native);
11051113
return;
11061114
}
11071115
// Notifications keep flowing during the RPC; release an absorbed stage only now.

0 commit comments

Comments
 (0)