Fix regression in parsing selector with trailing escaped colon

xzyfer · xzyfer · commit 62effe15b994 · 2018-03-30T13:34:03.000+11:00
Fixes sass#2625 Spec sass/sass-spec#1244
diff --git a/src/parser.cpp b/src/parser.cpp
@@ -2791,6 +2791,7 @@ namespace Sass {
       >(p)
     ) {
       bool could_be_property = peek< sequence< exactly<'-'>, exactly<'-'> > >(p) != 0;
+      bool could_be_escaped = false;
       while (p < q) {
         // did we have interpolations?
         if (*p == '#' && *(p+1) == '{') {
@@ -2799,9 +2800,10 @@ namespace Sass {
         }
         // A property that's ambiguous with a nested selector is interpreted as a
         // custom property.
-        if (*p == ':') {
+        if (*p == ':' && !could_be_escaped) {
           rv.is_custom_property = could_be_property || p+1 == q || peek< space >(p+1);
         }
+        could_be_escaped = *p == '\\';
         ++ p;
       }
       // store anyway  }

Original file line number	Diff line number	Diff line change
`@@ -2791,6 +2791,7 @@ namespace Sass {`
`2791`	`2791`	`>(p)`
`2792`	`2792`	`) {`
`2793`	`2793`	`bool could_be_property = peek< sequence< exactly<'-'>, exactly<'-'> > >(p) != 0;`
	`2794`	`+ bool could_be_escaped = false;`
`2794`	`2795`	`while (p < q) {`
`2795`	`2796`	`// did we have interpolations?`
`2796`	`2797`	`if (p == '#' && (p+1) == '{') {`
`@@ -2799,9 +2800,10 @@ namespace Sass {`
`2799`	`2800`	`}`
`2800`	`2801`	`// A property that's ambiguous with a nested selector is interpreted as a`
`2801`	`2802`	`// custom property.`
`2802`		`- if (*p == ':') {`
	`2803`	`+ if (*p == ':' && !could_be_escaped) {`
`2803`	`2804`	`rv.is_custom_property = could_be_property \|\| p+1 == q \|\| peek< space >(p+1);`
`2804`	`2805`	`}`
	`2806`	`+ could_be_escaped = *p == '\\';`
`2805`	`2807`	`++ p;`
`2806`	`2808`	`}`
`2807`	`2809`	`// store anyway }`