[drop counters] Clarify log messages for initial counter setup (sonic-net#1445)

daall · web-flow · commit 0b2e59ab6b90 · 2020-09-23T11:36:18.000-07:00
Signed-off-by: Danny Allen &lt;daall@microsoft.com&gt;
diff --git a/orchagent/debugcounterorch.cpp b/orchagent/debugcounterorch.cpp
@@ -322,9 +322,9 @@ task_process_status DebugCounterOrch::addDropReason(const string& counter_name,
         // are received before the create counter update, we keep track of reasons
         // we've seen in the free_drop_reasons table.
         addFreeDropReason(counter_name, drop_reason);
-        reconcileFreeDropCounters(counter_name);
+        SWSS_LOG_NOTICE("Added drop reason %s to drop counter %s", drop_reason.c_str(), counter_name.c_str());
 
-        SWSS_LOG_NOTICE("Succesfully created drop counter %s", counter_name.c_str());
+        reconcileFreeDropCounters(counter_name);
         return task_process_status::task_success;
     }
 
@@ -451,7 +451,7 @@ void DebugCounterOrch::reconcileFreeDropCounters(const string& counter_name)
         createDropCounter(counter_name, counter_it->second, reasons_it->second);
         free_drop_counters.erase(counter_it);
         free_drop_reasons.erase(reasons_it);
-        SWSS_LOG_NOTICE("Succesfully created new drop counter %s", counter_name.c_str());
+        SWSS_LOG_NOTICE("Succesfully matched drop reasons to counter %s", counter_name.c_str());
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -322,9 +322,9 @@ task_process_status DebugCounterOrch::addDropReason(const string& counter_name,`
`322`	`322`	`// are received before the create counter update, we keep track of reasons`
`323`	`323`	`// we've seen in the free_drop_reasons table.`
`324`	`324`	`addFreeDropReason(counter_name, drop_reason);`
`325`		`- reconcileFreeDropCounters(counter_name);`
	`325`	`+ SWSS_LOG_NOTICE("Added drop reason %s to drop counter %s", drop_reason.c_str(), counter_name.c_str());`
`326`	`326`
`327`		`- SWSS_LOG_NOTICE("Succesfully created drop counter %s", counter_name.c_str());`
	`327`	`+ reconcileFreeDropCounters(counter_name);`
`328`	`328`	`return task_process_status::task_success;`
`329`	`329`	`}`
`330`	`330`
`@@ -451,7 +451,7 @@ void DebugCounterOrch::reconcileFreeDropCounters(const string& counter_name)`
`451`	`451`	`createDropCounter(counter_name, counter_it->second, reasons_it->second);`
`452`	`452`	`free_drop_counters.erase(counter_it);`
`453`	`453`	`free_drop_reasons.erase(reasons_it);`
`454`		`- SWSS_LOG_NOTICE("Succesfully created new drop counter %s", counter_name.c_str());`
	`454`	`+ SWSS_LOG_NOTICE("Succesfully matched drop reasons to counter %s", counter_name.c_str());`
`455`	`455`	`}`
`456`	`456`	`}`
`457`	`457`