Repository navigation
Commit cf37f8d
committed
[web] Honor getTargetSize when upscaling in instantiateImageCodecWithSize
Fixes flutter#195193
instantiateImageCodecWithSize already applies the caller's upscaling
policy via getTargetSize (for example ResizeImage.allowUpscaling).
Passing a hardcoded allowUpscaling: false then clamped the decoded
image back to its intrinsic size, so ResizeImage(allowUpscaling: true)
could not upscale on web.
Honor the returned target size, matching dart:ui, and enable the
ResizeImage resizing tests on browser.
Co-authored-by: Sankalp Thakur <[email protected]>1 parent 0081d31 commit cf37f8d
3 files changed
Lines changed: 41 additions & 2 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib
- test/ui
- packages/flutter/test/painting
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
759 | 759 | | |
760 | 760 | | |
761 | 761 | | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
762 | 766 | | |
763 | 767 | | |
764 | 768 | | |
765 | 769 | | |
766 | | - | |
767 | 770 | | |
768 | 771 | | |
769 | 772 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
149 | 185 | | |
150 | 186 | | |
151 | 187 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
619 | 619 | | |
620 | 620 | | |
621 | 621 | | |
622 | | - | |
| 622 | + | |
623 | 623 | | |
624 | 624 | | |
625 | 625 | | |
| |||
0 commit comments