Skip to content

chore(dashboard): remove stray UI components directory - #37

Open
Subodh-17 wants to merge 1 commit into
sanjaysaini383:mainfrom
Subodh-17:chore/remove-stray-dashboard-components
Open

Subodh-17 wants to merge 1 commit into
sanjaysaini383:mainfrom
Subodh-17:chore/remove-stray-dashboard-components

Conversation

@Subodh-17

@Subodh-17 Subodh-17 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove the obsolete dashboard/@/components/ui/ directory containing nine unused component and variant files.
  • Keep the canonical UI components under dashboard/src/components/ui/.
  • Update dashboard regression checks to validate the canonical component paths.
  • Add a regression assertion ensuring the stray dashboard/@/ directory does not reappear.

Root Cause

The stray directory was created during initial scaffolding instead of using the configured @ alias, which resolves to dashboard/src.

The removed components were not referenced by application code. The orphaned button also depended on an uninstalled @base-ui/react/button package.

Validation

  • Dashboard tests: 9 passed.
  • Dashboard ESLint: 0 errors, 0 warnings.
  • Dashboard production build: passed.
  • Kafka consumer tests: 11 passed.
  • Query API tests: 7 passed.
  • git diff --check: passed.

Scope

  • 9 obsolete files deleted.
  • 1 regression test file updated.
  • No new dependencies introduced.
  • No unrelated application source or configuration changes.

Fixes #24

Summary by CodeRabbit

  • Chores
    • Removed several reusable dashboard interface elements, including alerts, badges, buttons, cards, tables, and tabs.
    • Updated regression checks to reflect the dashboard’s current component structure. These changes do not describe a new end-user feature.

@vercel

vercel Bot commented Nov 5, 2026

Copy link
Copy Markdown

@Subodh-17 is attempting to deploy a commit to the Sanjay Kumar Saini's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request removes unused UI components from the dashboard’s literal @ directory. It updates regression tests to check components under src and to assert that the @ directory does not exist.

Changes: Dashboard UI directory cleanup

Layer / File(s) Summary
Remove stray UI modules
dashboard/@/components/ui/*
Deletes the alert, badge, button, card, table, and tabs components and variant definitions from the literal @ directory.
Update dashboard regression checks
dashboard/test/regression.test.js
Scopes lint checks to src, updates component and variant export checks to use src/components/ui, and adds a check that the dashboard root has no @ directory.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Low

Possibly related PRs

Suggested reviewers: sanjaysaini383

Merge Risk: Minimal · up to 28f6e

The PR removes unused duplicate UI files without affecting supported dashboard imports or the canonical component layout.

Architecture risk: Low · up to 28f6e

The change affects 1 system.

Changed systems: dashboard

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — dashboard (ui) was modified; 10 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in dashboard/@/components/ui/alert.tsx: The file was deleted, removing the alert style variants and the Alert, AlertTitle, AlertDescription, and AlertAction component declarations and exports.
  • observed — Modified behavior in dashboard/@/components/ui/badge-variants.ts: The file was deleted, removing the badgeVariants export, its common badge classes, the default, secondary, destructive, outline, ghost, and link variant styles, and the default variant selection.
  • observed — Modified behavior in dashboard/@/components/ui/badge.tsx: The file and its exported Badge component were deleted, including its span rendering, prop merging, variant styling, default variant, and render state.
  • observed — Modified behavior in dashboard/@/components/ui/button-variants.ts: The file defining and exporting buttonVariants was deleted, including its shared button classes, variant and size options, and default variant and size.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the obsolete dashboard/@/ UI components directory.
Linked Issues check Passed Issue #24 requires removal of dashboard/@/ and preservation of dashboard build and lint behavior. The pull request deletes the nine files under the stray directory. The regression test now checks th…
Out of Scope Changes check Passed The changes stay within Issue #24. They delete the obsolete duplicate UI files and update the related dashboard regression checks. The added absence assertion directly prevents regression. No unrelate…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Linked Issues check

Explanation

Issue #24 requires removal of dashboard/@/ and preservation of dashboard build and lint behavior. The pull request deletes the nine files under the stray directory. The regression test now checks that dashboard/@ does not exist and checks canonical src/components/ui paths. The reported dashboard build passed, and the reported dashboard lint passed with zero errors and zero warnings.

Full details: Out of Scope Changes check

Explanation

The changes stay within Issue #24. They delete the obsolete duplicate UI files and update the related dashboard regression checks. The added absence assertion directly prevents regression. No unrelated application, dependency, or configuration changes are reported.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3e44f375-1b07-41ce-b145-448d466e9829
Commits

Reviewing files that changed from the base of the PR and between 036e6b9 and 28f6e60.

Files selected for processing: 10

  • dashboard/@/components/ui/alert.tsx
  • dashboard/@/components/ui/badge-variants.ts
  • dashboard/@/components/ui/badge.tsx
  • dashboard/@/components/ui/button-variants.ts
  • dashboard/@/components/ui/button.tsx
  • dashboard/@/components/ui/card.tsx
  • dashboard/@/components/ui/table.tsx
  • dashboard/@/components/ui/tabs-variants.ts
  • dashboard/@/components/ui/tabs.tsx
  • dashboard/test/regression.test.js
Files with no reviewable changes: 9

  • dashboard/@/components/ui/alert.tsx
  • dashboard/@/components/ui/tabs-variants.ts
  • dashboard/@/components/ui/button.tsx
  • dashboard/@/components/ui/badge-variants.ts
  • dashboard/@/components/ui/card.tsx
  • dashboard/@/components/ui/button-variants.ts
  • dashboard/@/components/ui/badge.tsx
  • dashboard/@/components/ui/table.tsx
  • dashboard/@/components/ui/tabs.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] Remove the stray dashboard/@/components/ui directory

1 participant