fix: improve ESM output to support Deno, Bun and Edge runtimes#29
Merged
fix: improve ESM output to support Deno, Bun and Edge runtimes#29
Conversation
rexxars
approved these changes
Sep 14, 2022
Member
rexxars
left a comment
rexxars
left a comment
There was a problem hiding this comment.
Nice work! Have not tested this in all environments, but trust that you have and the tests we have in place are sufficient :)
Still think we should release this as a major version, just in case.
stipsan
force-pushed
the
improve-esm
branch
2 times, most recently
from
0198f9a to
ffb3c94
Compare
Contributor
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #13.
Based on new research and findings on how conditional package exports actually works in Bun, Deno, Cloudflare Workers and Edge runtimes.
Blocked by sanity-io/get-it#25Testable by
As well as