Add default to response.cookies (#3047)

ahopkins · web-flow · commit 1f97c3c72970 · 2025-03-31T09:51:17.000+03:00
* Cleanup some typing

* Add custom CLI commands

* Add unit tests

* Add default to response cookies
diff --git a/guide/content/en/emoji.py b/guide/content/en/emoji.py
diff --git a/guide/webapp/display/markdown.py b/guide/webapp/display/markdown.py
@@ -56,7 +56,7 @@ def heading(self, text: str, level: int, **attrs) -> str:
             {
                 "id": ident,
                 "class": (
-                    f"is-size-{level}-desktop " f"is-size-{level+2}-touch"
+                    f"is-size-{level}-desktop is-size-{level + 2}-touch"
                 ),
             },
             text,
diff --git a/guide/webapp/display/plugins/tabs.py b/guide/webapp/display/plugins/tabs.py
@@ -50,5 +50,5 @@ def _render_tab(self, renderer: HTMLRenderer, text: str, **attrs):
             else ""
         )
         content = f'<div class="tab-content">{text}</div>\n'
-        tab = f'<li><a>{attrs["title"]}</a>{content}</li>\n'
+        tab = f"<li><a>{attrs['title']}</a>{content}</li>\n"
         return start + tab + end
diff --git a/sanic/cookies/response.py b/sanic/cookies/response.py
@@ -73,7 +73,7 @@ def cookies(self) -> list[Cookie]:
         Returns:
             List[Cookie]: A list of cookies in the CookieJar.
         """
-        return self.headers.getall(self.HEADER_KEY)
+        return self.headers.getall(self.HEADER_KEY, [])
 
     def get_cookie(
         self,
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -250,9 +250,9 @@ def test_auto_reload(cmd: str, caplog, port):
     info = read_app_info(lines)
 
     assert info["debug"] is False, f"Unexpected value of debug {info}"
-    assert (
-        info["auto_reload"] is True
-    ), f"Unexpected value of auto reload {info}"
+    assert info["auto_reload"] is True, (
+        f"Unexpected value of auto reload {info}"
+    )
 
 
 @pytest.mark.parametrize(
@@ -273,9 +273,9 @@ def test_access_logs(cmd: str, expected: bool, caplog, port):
     info = read_app_info(lines)
     if info["access_log"] != expected:
         print(lines)
-    assert (
-        info["access_log"] is expected
-    ), f"Expected: {expected}. Received: {info}. Lines: {lines}"
+    assert info["access_log"] is expected, (
+        f"Expected: {expected}. Received: {info}. Lines: {lines}"
+    )
 
 
 @pytest.mark.parametrize("cmd", ("--version", "-v"))
diff --git a/tests/test_headers.py b/tests/test_headers.py
@@ -386,12 +386,10 @@ def test_accept_misc():
     )
     a = headers.parse_accept(header)
     assert repr(a) == (
-        "[*/plain;param=123, text/plain, text/*, "
-        "foo/bar;q=0.5, foo/bar;q=0.0]"
+        "[*/plain;param=123, text/plain, text/*, foo/bar;q=0.5, foo/bar;q=0.0]"
     )  # noqa: E501
     assert str(a) == (
-        "*/plain;param=123, text/plain, text/*, "
-        "foo/bar;q=0.5, foo/bar;q=0.0"
+        "*/plain;param=123, text/plain, text/*, foo/bar;q=0.5, foo/bar;q=0.0"
     )  # noqa: E501
     # q=1 types don't match foo/bar but match the two others,
     # text/* comes first and matches */plain because it
diff --git a/tests/test_request.py b/tests/test_request.py
@@ -80,7 +80,7 @@ async def get(request):
         "/", headers={"X-REQUEST-ID": f"{request_id}"}
     )
     assert request.id == request_id
-    assert type(request.id) == expected_type
+    assert type(request.id) is expected_type
 
 
 def test_custom_generator():
diff --git a/tests/test_routes.py b/tests/test_routes.py
@@ -1121,7 +1121,7 @@ def handler(request):
             return text("pass")
 
     assert str(excinfo.value) == (
-        "Expected either string or Iterable of " "host strings, not {!r}"
+        "Expected either string or Iterable of host strings, not {!r}"
     ).format(host)
 
 
diff --git a/tests/test_views.py b/tests/test_views.py
@@ -195,9 +195,7 @@ def _iternal_method(self):
 
         def get(self, request):
             self._iternal_method()
-            return text(
-                f"I am get method and global var " f"is {self.global_var}"
-            )
+            return text(f"I am get method and global var is {self.global_var}")
 
     app.add_route(DummyView.as_view(), "/")
     request, response = app.test_client.get("/")

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ def heading(self, text: str, level: int, **attrs) -> str:`
`56`	`56`	`{`
`57`	`57`	`"id": ident,`
`58`	`58`	`"class": (`
`59`		`- f"is-size-{level}-desktop " f"is-size-{level+2}-touch"`
	`59`	`+ f"is-size-{level}-desktop is-size-{level + 2}-touch"`
`60`	`60`	`),`
`61`	`61`	`},`
`62`	`62`	`text,`
Original file line number	Diff line number	Diff line change
`@@ -50,5 +50,5 @@ def _render_tab(self, renderer: HTMLRenderer, text: str, **attrs):`
`50`	`50`	`else ""`
`51`	`51`	`)`
`52`	`52`	`content = f'<div class="tab-content">{text}</div>\n'`
`53`		`- tab = f'<li><a>{attrs["title"]}</a>{content}</li>\n'`
	`53`	`+ tab = f"<li><a>{attrs['title']}</a>{content}</li>\n"`
`54`	`54`	`return start + tab + end`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ async def get(request):`
`80`	`80`	`"/", headers={"X-REQUEST-ID": f"{request_id}"}`
`81`	`81`	`)`
`82`	`82`	`assert request.id == request_id`
`83`		`- assert type(request.id) == expected_type`
	`83`	`+ assert type(request.id) is expected_type`
`84`	`84`
`85`	`85`
`86`	`86`	`def test_custom_generator():`