Fix active and inactive tab playback and stalling for player - #939
Merged
Conversation
cjcolvar
approved these changes
Apr 20, 2026
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
Great job handling these iOS quirks! This looks good to me but there are some merge conflicts that need to be resolved.
Dananji
force-pushed
the
multi-tab-playback
branch
from
April 21, 2026 17:42
7c0786f to
70210e6
Compare
cjcolvar
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #714
Changes in this PR:
visibilitychangelistener ininitializeEventHandlers(ramp-hooks.js) that pauses the player when the tab becomes inactive and resumes it when the tab becomes active again, preventing the playhead from advancing while the tab is inactive on iOS/iPadOSMath.max(currentTimeRef.current, player.currentTime())withcurrentTimeRef.currentwhen setting the seek target inplayerLoadedMetadataevent, because iOS can advanceplayer.currentTime()in the background before thevisibilitychangepause takes effect, causing the player'sseekevent to jump-forward on next loadstalledevent listener for iOS in to recover from stalling that happens in audio player. When VideoJSstalledevent fires withreadyState < 3, callplayer.load()andplayer.play()to un-stuck the player