Skip to content

Open playback-rate menu downwards for audio players in mobile browsers - #927

Merged
Dananji merged 3 commits into
mainfrom
playbackrate-menu
Apr 7, 2026
Merged

Open playback-rate menu downwards for audio players in mobile browsers#927
Dananji merged 3 commits into
mainfrom
playbackrate-menu

Conversation

@Dananji

@Dananji Dananji commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

Related issue: #698

@Dananji
Dananji marked this pull request as draft April 2, 2026 23:25
@Dananji
Dananji marked this pull request as ready for review April 3, 2026 16:08

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I wonder if it could be applied to other cases based on dimensions and not just platform.

@Dananji

Dananji commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator Author

Great suggestion! - yes, I think this is feasible.
This could be an issue on desktop browsers as well when the audio player is placed near the top of the page.
For a dimension-based approach, we could figure out the space available on top of the player and move the menu as needed. I will create a new ticket to work on this.

@Dananji
Dananji merged commit b23b157 into main Apr 7, 2026
4 checks passed
@Dananji
Dananji deleted the playbackrate-menu branch April 7, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants