Skip to content

Display player controls in error state - #893

Merged
Dananji merged 1 commit into
mainfrom
vjs-error-controls
Dec 11, 2025
Merged

Display player controls in error state#893
Dananji merged 1 commit into
mainfrom
vjs-error-controls

Conversation

@Dananji

@Dananji Dananji commented Dec 10, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #878

Changes in this PR:

  • display player controls in the player's error state for multi-canvas manifests to provide users the ability to navigate between canvases. In this state only the previous/next buttons are enabled to allow canvas navigation
multi-canvas error
  • hide player controls in the player's error state for single-canvas manifests
single-canvas error

cjcolvar
cjcolvar approved these changes Dec 10, 2025
View reviewed changes

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell without testing. Nice to have this better UX!

@Dananji
Dananji merged commit 34087ce into main Dec 11, 2025
2 checks passed
@Dananji
Dananji deleted the vjs-error-controls branch December 11, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dananji @cjcolvar