Add fallback strategy for source selection - #890
Merged
Merged
Conversation
Dananji
marked this pull request as draft
December 6, 2025 00:21
Dananji
force-pushed
the
fallback-source
branch
2 times, most recently
from
December 9, 2025 18:00
46be894 to
48834d4
Compare
Dananji
marked this pull request as ready for review
December 9, 2025 19:25
cjcolvar
approved these changes
Dec 9, 2025
cjcolvar
left a comment
Member
There was a problem hiding this comment.
This code looks good to me. I think it will be good to get this into Avalon to test it out thoroughly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #872
Changes in this PR:
Implemented source fallback functionality for
VideoJS,@silvermine/videojs-quality-selectorplugin. With this fix, when a source choice in quality selector fails to load, the player automatically cycles through available sources until one works. While trying available source choices it marks unavailable sources choices in the quality selector menu. If all sources fail an error message is displayed usingVideoJS' error modal.When the player encounters a failing source that particular source gets disabled in the quality selector for the player session (until page is reloaded, or switched to another Canvas) and an error is logged to the
devToolsconsole.When all sources fail an error is displayed using
VideoJS's error modal.When 2 consecutive source segments are failing in a multi-sourced Canvas the error message is displayed as a non-dismissable toast notification before loading the next viable available segment.
Screen.Recording.2025-12-09.at.10.01.10.AM.mov