Fix transcript/annotation sync with playback for multi-source Canvas - #889
Conversation
cjcolvar
left a comment
cjcolvar
left a comment
There was a problem hiding this comment.
Looks great as far as I can tell!
I was hoping to do some manual testing with the IA manifest mentioned in the issue but I'm getting a 504 when attempting to fetch it.
Also I tried the opera one canvas cookbook manifest and it breaks when trying to go to the second source of the canvas. This is the error I'm seeing:
TypeError: can't access property "selected", originalQuality is undefined
setSelectedQuality ramp-hooks.js:584
useVideoJSPlayer ramp-hooks.js:381
Is it expected to work or does that recipe's manifest need fixing?
|
@cjcolvar I just checked the IA Manifest and it is working now. This Manifest link has been flaky. As for the cookbook recipe, I am unable re-produce the error you were seeing. But I will add a check for the |
|
I'm still running into the same issue with the opera canvas when I try to seek into the 2nd source ( The IA manifest worked this time and it looks like transcript/annotations are in sync but the displayed captions don't seem to get switched out with the video source so the captions for the first 60 second source repeat for each source. |
It'd be helpful if you can mention the steps you followed to get the error because I'm unable to reproduce the error. I tried scrubbing the progress bar and using the structured navigation to seek to the second source while the player is paused and playing. Or if it's easier we can hop onto Zoom to discuss this..
Yes! We may need a separate ticket to work on this. This synchronization is handled by VideoJS so it will need some investigation.. |
|
I refreshed my checkout and the cookbook recipe worked this time. 🎉 |
2 participants
Related issue: #884
Changes in this PR:
currentTimecalcualation in theuseMediaPlayercustom hook to consider alternate start times for multi-sourced canvases