Skip to content

Fix search highlights for searches with punctuation in untimed transcripts - #855

Merged
Dananji merged 3 commits into
mainfrom
fix-untimed-search
Aug 19, 2025
Merged

Fix search highlights for searches with punctuation in untimed transcripts#855
Dananji merged 3 commits into
mainfrom
fix-untimed-search

Conversation

@Dananji

@Dananji Dananji commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #853

The skipped unit tests towards the end of the Transcript.test.js needs to be re-evaluated as part of #857. The first test might be irrelevant to this unit, and the second one addresses the inline annotations in Aviary manifest, which is addressed in the linked issue.

@Dananji
Dananji marked this pull request as ready for review July 30, 2025 21:51

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread src/services/search-parser.js
@Dananji
Dananji merged commit e2ca564 into main Aug 19, 2025
2 checks passed
@Dananji
Dananji deleted the fix-untimed-search branch August 19, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants