Skip to content

Remove untimed search hits and preserve inline styling for search within - #852

Merged
Dananji merged 2 commits into
mainfrom
search-within-transcript
Jul 25, 2025
Merged

Remove untimed search hits and preserve inline styling for search within#852
Dananji merged 2 commits into
mainfrom
search-within-transcript

Conversation

@Dananji

@Dananji Dananji commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

Related issue: #847

Changes:

  • apply highlights from search response to the styled transcript text in Ramp to preserve styling specified in the transcript file. This change is specifically for timed text in WEBVTT files
  • remove items in the search response without media-fragment information for timed transcripts

@Dananji
Dananji marked this pull request as draft July 24, 2025 15:02
@Dananji
Dananji marked this pull request as ready for review July 24, 2025 16:49

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell.

@Dananji

Dananji commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator Author

Keeping this without merging until Jon Cameron has had a chance to look at the issue and the impact on release testing (for Ramp 4.1.0 and Avalon 8.1) if this work is brought into Avalon.

@Dananji
Dananji merged commit 75feea1 into main Jul 25, 2025
2 checks passed
@Dananji
Dananji deleted the search-within-transcript branch July 25, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants