Browser determined download for files tab - #849
Merged
Conversation
cjcolvar
force-pushed
the
browser-determined-download
branch
from
July 17, 2025 17:44
c082489 to
fd6e8ef
Compare
cjcolvar
marked this pull request as ready for review
July 17, 2025 17:59
Dananji
approved these changes
Jul 17, 2025
Dananji
left a comment
Dananji
left a comment
Collaborator
There was a problem hiding this comment.
This looks good 👍
As for the build files, I like not including build files in PRs because it makes
- the PR cleaner
- the merging process easier when there are multiple PRs, which shouldn't be an issue with this
And I'm okay with merging this as it it.
If it helps, what I do when I need to test things in Avalon I run yarn build and then yarn pack to create a .tgz file, which I then move to avalon workspace and install with yarn using yarn add ./samvera-ramp-v4.0.0.tgz
Member
Author
|
Thanks, I forgot about the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of avalonmediasystem/avalon#6399
Related to #840
This PR removes the special handling of links from the SupplementalFiles component allowing the server serving those urls to supply appropriate content disposition headers that would allow the file to be rendered inline in the browser instead of forcing download.
It appears that the
downloadattribute on anchor tags makes Chrome and Firefox download ignoring the inline content disposition header if present. See final note in MDN docs.I included a build in this PR so I could test it out in avalon. If it is better for that to be taken out and happen in another PR I'm happy to do so.