Show time rail highlight for current timespan when nested - #784
Merged
Conversation
Dananji
marked this pull request as draft
March 14, 2025 13:08
Dananji
marked this pull request as ready for review
March 14, 2025 16:10
cjcolvar
reviewed
Mar 18, 2025
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
Looks great overall! It will be cool to see this in action.
cjcolvar
approved these changes
Mar 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #779
To test nested timespans in Ramp demo site use the example Manifest at: https://gist.githubusercontent.com/Dananji/6575bff0213ca42af36009650fa986de/raw/857c759675c84acabe900f35838295613e369bb8/nested-timespans.json