Explicitly update played range - #733
Merged
Merged
Conversation
, and remove abortable timeupdate handler for Safari
cjcolvar
approved these changes
Nov 12, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
Looks good as far as I can tell. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #701
Update played range for mobile devices in the timeupdate handler, this helpful with updating progress-bar when the user is structured navigation.
NOTE: I was seeing laggy updates for the same steps in Safari in desktop, which was not reported in the ticket.
To solve this, I removed the abortable time-update handler we were using in the progress-bar. This is part of the previous implementation where, we built the progress-bar from scratch.
It seems with the refactor of the progress-bar component to use VideoJS' native component solved the issue we were trying to solve with the abortable time-update handler (laggy time-updates and jumping back and forth when scrubbing/seeking in Safari browsers).
In my initial testing during development, I was not seeing any issues with this change,. But this needs to be tested thoroughly across platforms and browsers.