Fix collapse/expand all button behavior with each section status change - #729
Merged
Conversation
Dananji
force-pushed
the
collapse-all-fix
branch
from
November 11, 2024 18:44
04cbbf6 to
6b032e3
Compare
Dananji
marked this pull request as ready for review
November 11, 2024 18:51
Dananji
changed the title
cjcolvar
approved these changes
Nov 11, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
I'm a bit confused by the code but I did some manual testing and it all looked good as far as I could tell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: #645 , #731, #732
Update collapse/expand all button when each section is changed manually:
Screen.Recording.2024-11-11.at.1.41.51.PM.mov
Expand current section when playback status changes for it:
Screen.Recording.2024-11-11.at.1.50.39.PM.mov