Skip to content

Wrap long labels w/o spaces in structure to new lines - #693

Merged
Dananji merged 2 commits into
mainfrom
long-section-labels
Oct 31, 2024
Merged

Wrap long labels w/o spaces in structure to new lines#693
Dananji merged 2 commits into
mainfrom
long-section-labels

Conversation

@Dananji

@Dananji Dananji commented Oct 29, 2024

Copy link
Copy Markdown
Collaborator

Related issue: #675

Section headings:
Before:
Screenshot 2024-10-29 at 5 39 45 PM

After:
Screenshot 2024-10-29 at 5 38 25 PM

Child structure items:
Before:
Screenshot 2024-10-29 at 5 39 56 PM

After:
Screenshot 2024-10-29 at 5 35 56 PM

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall just had one question.

Comment thread src/components/StructuredNavigation/NavUtils/SectionHeading.js
@Dananji Dananji mentioned this pull request Oct 30, 2024
@Dananji
Dananji force-pushed the long-section-labels branch from 9cfb8a5 to 35dbecd Compare October 30, 2024 18:51

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dananji
Dananji merged commit 4a1d460 into main Oct 31, 2024
@Dananji
Dananji deleted the long-section-labels branch October 31, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants