Create inaccessible message interval only in a single custom hook - #690
Merged
Conversation
Dananji
force-pushed
the
auto-advance-fix
branch
from
October 28, 2024 21:06
d81dc1a to
5ddb2f1
Compare
cjcolvar
approved these changes
Oct 29, 2024
cjcolvar
left a comment
Member
There was a problem hiding this comment.
Great work! This seems like it was really tricky to find!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #673
Only invoke
createDisplayTimeInterval()method withinuseShowInaccessibleMessagecustom hook. When this was called withininitCanvas()inuseSetupPlayerhook, it creates multiple intervals disabling the remaining time updates in the timer on display.Use
canvasIndexinstead ofcanvasIndexRefin the dispatch to update manifest-state when timer ends.It was observed that, in Safari and Chrome using
canvasIndexRefcauses to skip an item when auto-advancing (most probably due to timing of these updates are getting overlapped) in avalon's playlists where there are inaccessible items. However this was not seen in these browsers in the demo site.