Skip to content

Create inaccessible message interval only in a single custom hook - #690

Merged
Dananji merged 1 commit into
mainfrom
auto-advance-fix
Oct 29, 2024
Merged

Create inaccessible message interval only in a single custom hook#690
Dananji merged 1 commit into
mainfrom
auto-advance-fix

Conversation

@Dananji

@Dananji Dananji commented Oct 28, 2024

Copy link
Copy Markdown
Collaborator

Related issue: #673

Only invoke createDisplayTimeInterval() method within useShowInaccessibleMessage custom hook. When this was called within initCanvas() in useSetupPlayer hook, it creates multiple intervals disabling the remaining time updates in the timer on display.
Use canvasIndex instead of canvasIndexRef in the dispatch to update manifest-state when timer ends.
It was observed that, in Safari and Chrome using canvasIndexRef causes to skip an item when auto-advancing (most probably due to timing of these updates are getting overlapped) in avalon's playlists where there are inaccessible items. However this was not seen in these browsers in the demo site.

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This seems like it was really tricky to find!

@Dananji
Dananji merged commit 9afc7c7 into main Oct 29, 2024
@Dananji
Dananji deleted the auto-advance-fix branch October 29, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants