Replace volume control with muteToggle/volumePanel, popup menus above progress-bar - #669
Merged
Conversation
Dananji
marked this pull request as ready for review
October 18, 2024 18:54
cjcolvar
reviewed
Oct 21, 2024
… above progress-bar
Co-authored-by: Chris Colvard <[email protected]>
Dananji
force-pushed
the
volumepanel-657
branch
from
October 21, 2024 17:00
a728c13 to
8f6e201
Compare
cjcolvar
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #657
This PR includes the following changes;
hoverevent on the buttons are removed. This seems to be the common practice in other platforms e.g. LinkedInLearning and YouTube.