Refine progress-bar by using VideoJS' native ProgressControl - #664
Merged
Conversation
Dananji
changed the title
cjcolvar
approved these changes
Oct 21, 2024
Member
There was a problem hiding this comment.
Looks good as far as I can tell. It would be nice if there was a cleaner way to override the seek bar implementation in VideoJS so you don't have to override the progress control suppress the native seekbar and forward events but that is probably unavoidable. Overall still seems better than everything custom as it was before.
Collaborator
Author
|
Yes, this is not ideal 💯 There's probably a better way to do this, which I want to explore as I get time in the future 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #637