Skip to content

Fix minor bugs in player introduced in refactor/cleanup work - #662

Merged
Dananji merged 4 commits into
mainfrom
minor-player-fixes
Oct 14, 2024
Merged

Fix minor bugs in player introduced in refactor/cleanup work#662
Dananji merged 4 commits into
mainfrom
minor-player-fixes

Conversation

@Dananji

@Dananji Dananji commented Oct 10, 2024

Copy link
Copy Markdown
Collaborator

This PR includes the following;

  1. Cleanup of playerFocusElement global state variable, as this is not needed anymore to retain focus for previous/next button keyboard navigation with the changes done on these custom components with new implementation
  2. Remove float: inline-end styling with display: inline-block for player controls to right align some of the controls in the player, as this reverses the tab order of the controls when using keyboard navigation. Replace this styling to use display: flex
  3. Fix a bug in the state updates for persisting the player's play/pause status as isPlaying in global state with hotkey implementation and pointer events
  4. Set aspect ratio for inaccessible message display as 16/9 (equivalent to video player) when switching from an audio item to inaccessible item
  5. Attach player hotkeys event handler upon player creation, as hotkeys doesn't work as expected with the previous implementation when the first item is an inaccessible item.

@Dananji
Dananji marked this pull request as ready for review October 11, 2024 15:17
@Dananji
Dananji force-pushed the minor-player-fixes branch 2 times, most recently from 07154ad to afe7ab7 Compare October 11, 2024 15:24
@Dananji
Dananji marked this pull request as draft October 11, 2024 15:25
@Dananji
Dananji force-pushed the minor-player-fixes branch from afe7ab7 to 23b7b38 Compare October 11, 2024 15:55
@Dananji
Dananji marked this pull request as ready for review October 11, 2024 15:57
Comment thread src/services/ramp-hooks.js Outdated

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dananji
Dananji merged commit 5d15ca7 into main Oct 14, 2024
@Dananji
Dananji deleted the minor-player-fixes branch October 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants