Fix minor bugs in player introduced in refactor/cleanup work - #662
Merged
Conversation
Dananji
marked this pull request as ready for review
October 11, 2024 15:17
Dananji
force-pushed
the
minor-player-fixes
branch
2 times, most recently
from
October 11, 2024 15:24
07154ad to
afe7ab7
Compare
Dananji
marked this pull request as draft
October 11, 2024 15:25
Dananji
force-pushed
the
minor-player-fixes
branch
from
October 11, 2024 15:55
afe7ab7 to
23b7b38
Compare
Dananji
marked this pull request as ready for review
October 11, 2024 15:57
cjcolvar
reviewed
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following;
playerFocusElementglobal state variable, as this is not needed anymore to retain focus for previous/next button keyboard navigation with the changes done on these custom components with new implementationfloat: inline-endstyling withdisplay: inline-blockfor player controls to right align some of the controls in the player, as this reverses the tab order of the controls when using keyboard navigation. Replace this styling to usedisplay: flexisPlayingin global state with hotkey implementation and pointer events