Custom hook for MediaPlayer and VideoJSPlayer handling - #647
Merged
Conversation
Dananji
force-pushed
the
state-refactor4-630
branch
2 times, most recently
from
September 23, 2024 18:59
870cd1a to
f92b814
Compare
Dananji
marked this pull request as ready for review
September 24, 2024 20:35
cjcolvar
approved these changes
Sep 30, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
Looks great as far as I can tell!
Dananji
force-pushed
the
state-refactor4-630
branch
from
September 30, 2024 18:48
f94085a to
7d380c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #630
Includes custom hook implementations for player related state updates.
For some of the functionality in the custom hooks, unit tests are added. Most of the code in these hooks are covered by the unit tests in respective components' test-cases. Test coverage in the new module
@Services/ramp-hooks.jsadded in this work (#630) is around 70%. The parts that are not covered in tests are either impossible/hard to write tests with just the custom hook functionality.