State management refactor for structure - #643
Merged
Merged
Conversation
Dananji
marked this pull request as ready for review
September 18, 2024 19:02
cjcolvar
approved these changes
Sep 20, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
This looks really good!
Not in scope of this PR but when looking through it I thought the cyclical dependence of SectionHeading on List and List on SectionHeading is confusing. I wonder if having an abstract component with subclasses might help scope and conceptualize the different uses of the two components.
8 tasks
Collaborator
Author
That sounds good. I created a new issue to work on this #648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #630
Use custom hooks for structured navigation for state updates and subscriptions limiting re-renders of the component tree in the
StructuredNavigationcomponent. This lets us to use collapsible sections and then keep it collapsed or expanded while the state is getting updated in the background.For Avalon media object manifest: https://avalon-dev.dlib.indiana.edu/media_objects/g158bh28p/
For cookbook recipe: https://iiif.io/api/cookbook/recipe/0065-opera-multiple-canvases
For cookbook recipe: https://iiif.io/api/cookbook/recipe/0026-toc-opera
