Limit re-renders for AutoAdvanceToggle, SupplementalFiles, and MarkersDisplay components - #640
Merged
Conversation
cjcolvar
reviewed
Sep 17, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
This all looks great as far as I can tell!
I'm wondering if the new services/markers.js should be renamed to something more generic. It feels like it might continue to grow to hold other use methods since it seems like a useful pattern. Maybe services/ramp-hooks.js?
Member
|
A test is failing on node 18. With this being such a large refactor of ramp including changing react major versions do you think it makes sense to drop support for node 18 early and add node 22 to the test matrix? |
cjcolvar
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #630
Both AutoAdvanceToggle and SupplementalFiles components are mostly static components, which don't need to be re-renders with player and structure navigation updates.
As for MarkersDisplay component, it needs to be re-rendered on updates to the markers and Canvas changes.
The changes in this limit re-renders in these components and their child components as needed.