Convert vjs components - #635
Merged
Merged
Conversation
Dananji
force-pushed
the
convert-vjs-components
branch
from
September 7, 2024 15:46
f650926 to
0ab2bd8
Compare
Dananji
marked this pull request as ready for review
September 12, 2024 21:10
4 tasks
cjcolvar
reviewed
Sep 16, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
Overall looks really good! I like how this is removing a lot of useEffect hooks and making the code cleaner!
cjcolvar
reviewed
Sep 17, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
I really like how the enum makes the action explicit and handling with the switch easy to read.
cjcolvar
approved these changes
Sep 17, 2024
Co-authored-by: Chris Colvard <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #618
I tried React 19 RC upgrade to test bundling (not included in the PR), and it works well with the changes to the Video.js custom components in this PR.