Parsing refactor - #625
Merged
Merged
Conversation
Dananji
force-pushed
the
parsing-refactor-606
branch
from
August 19, 2024 21:18
5d16a7b to
8268279
Compare
Dananji
marked this pull request as ready for review
August 21, 2024 20:08
…ing into one method
…ility-parser unit tests
Dananji
force-pushed
the
parsing-refactor-606
branch
from
August 23, 2024 14:12
ded5f90 to
9593904
Compare
cjcolvar
approved these changes
Sep 3, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
This looks great! Getting rid of most of those parseManifest calls as well as manifesto objects and methods cleans it up a lot and probably will make it faster too!
I had a few small questions/suggestions but none of them are blocking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #606
Changes:
parseManifestfrommanifesto.jsas much as possible. Instead use JSON blob returned from the fetch request to read and parse relevant data for Ramp components (this is equivalent toloadManifestfunction inmanifesto.js).IIIFPlayerWrappercomponent as these values are needed in different components. Store this information in state to make available them to child components. This helps to save this information into state before storing manifest, which triggers rendering of child components.manifest-contextas these can be parsed and stored asynchronously in state to be used later.getMediaInfofunction including placeholderCanvas.Not changed:
parseManifestin parsingstructuresas this makes the parsing of ranges easier than using the JSON object of manifest. And this code is more clear and readable.Note
I missed the previous work done on the refactor done by @cjcolvar. But we should probably re-visit that when doing the state management work. I think this work is more related to asynchronous state management than parsing, which is one of the things we should probably look at as part of that refactor.