Sanitize manifest url if params included in middle - #623
Merged
Conversation
This commit is to fix an issue found with Ramp embedded in Avalon. If the request url from avalon has params on the end, Avalon feeds the entire url into Ramp as `https://example.com/endpoint?params/manifest.json`. This causes media to fail to load because it is not a valid manifest url. By removing the params from the middle of the url, we can get Ramp to request the proper manifest url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is to fix an issue found with Ramp embedded in Avalon. If the request url from Avalon has params on the end, Avalon feeds the entire url into Ramp as
https://example.com/endpoint?params/manifest.json. This causes media to fail to load because it is not a valid manifest url. By removing the params from the middle of the url, we can get Ramp to request the proper manifest url.Related issue: #615