Skip to content

Store captions on/off status in localstorage for session - #613

Merged
Dananji merged 3 commits into
mainfrom
sticky-captions-5651
Aug 19, 2024
Merged

Store captions on/off status in localstorage for session#613
Dananji merged 3 commits into
mainfrom
sticky-captions-5651

Conversation

@Dananji

@Dananji Dananji commented Aug 5, 2024

Copy link
Copy Markdown
Collaborator

Comment thread src/services/local-storage.js
@Dananji
Dananji marked this pull request as draft August 6, 2024 21:05
@Dananji
Dananji force-pushed the sticky-captions-5651 branch from 94a7b55 to 7523a11 Compare August 7, 2024 18:03
@Dananji
Dananji marked this pull request as ready for review August 7, 2024 18:04

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Dananji

Dananji commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator Author

I read about nullish coalesing operator just now, and thought that would suit this and would make the code cleaner.

Comment thread src/services/local-storage.js
@Dananji
Dananji merged commit 55ad1b8 into main Aug 19, 2024
@Dananji
Dananji deleted the sticky-captions-5651 branch August 19, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants