Update variables in progress component to refs to maintain accuracy with canvas updates - #587
Merged
Conversation
Dananji
force-pushed
the
safari-playback-fix-560
branch
from
July 25, 2024 16:20
ea4e413 to
665d0f0
Compare
Dananji
marked this pull request as ready for review
July 25, 2024 17:18
Dananji
force-pushed
the
safari-playback-fix-560
branch
from
July 26, 2024 13:54
665d0f0 to
7df110b
Compare
Dananji
marked this pull request as draft
July 26, 2024 14:04
Dananji
marked this pull request as ready for review
July 26, 2024 14:21
cjcolvar
reviewed
Jul 26, 2024
cjcolvar
approved these changes
Jul 26, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
Looks good as far as I can tell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #560
Merge this after 7.8 related Ramp release is createdAfter some discussion in Slack it was decided to merge this for 7.8 release since this has similar scope as #580 which is going to be in 7.8.