Add withCredentials option to MediaPlayer component - #576
Merged
Conversation
Dananji
approved these changes
Jul 18, 2024
Dananji
left a comment
Dananji
left a comment
Collaborator
There was a problem hiding this comment.
This looks good 👍
Thank you for the PR Michael!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #575
This PR adds a
withCredentialsboolean property to theMediaPlayercomponent to allow the underlying VideoJS component to include cookies and auth info in its XHR requests. Requires that the server be configured to include the correct CORS headers to allow the browser to send credentials. These requirements are included in the documentation of the new property.