Skip to content

Check if manfiestState exists for search service parsing - #572

Merged
Dananji merged 1 commit into
mainfrom
check-manifeststate
Jul 17, 2024
Merged

Check if manfiestState exists for search service parsing#572
Dananji merged 1 commit into
mainfrom
check-manifeststate

Conversation

@Dananji

@Dananji Dananji commented Jul 17, 2024

Copy link
Copy Markdown
Collaborator

Check existence of manifestState context in the search.js when trying to parse the search service from the given Manifest.
Without this check the transcript component crashes when used outside of the context providers.

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Dananji
Dananji merged commit bc5560d into main Jul 17, 2024
@Dananji
Dananji deleted the check-manifeststate branch July 17, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants