Small tweak to top margin of horizontal volume slider thumb - #562
Merged
Conversation
Dananji
reviewed
Jul 10, 2024
Dananji
left a comment
Dananji
left a comment
Collaborator
There was a problem hiding this comment.
It looks good from the attached screenshot in the PR.
But, in the ticket the screenshot shows that the thumb is below the volume slider bar unlike the before screenshot in the PR.
So, my guess is that increasing margin-top wouldn't work in the Avalon context, since this change pushes the thumb further down.
Other possible solutions:
- try using a different CSS property to align things properly (like
vertical-alignon the SVG)? - tweak this in Avalon code if there's no other way to fix this on the Ramp side?
What do you think @cjcolvar ?
Dananji
approved these changes
Jul 11, 2024
Dananji
left a comment
Dananji
left a comment
Collaborator
There was a problem hiding this comment.
Sorry, I didn't see that you had made the change in Avalon repo before. So, I guess this is good for Ramp side of things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Part of #559