Adjust content search when switching between transcripts - #532
Merged
Conversation
Dananji
marked this pull request as draft
June 24, 2024 13:25
Dananji
marked this pull request as ready for review
June 24, 2024 19:16
cjcolvar
reviewed
Jun 25, 2024
cjcolvar
left a comment
cjcolvar
left a comment
Member
There was a problem hiding this comment.
I did a little testing and search feels improved. I ran into a couple inconsistencies:
- highlighting words within other words (e.g.
youandyour) - phrase searching correctly highlights but hit count is 0 (e.g.
feeling better)
Dananji
marked this pull request as draft
June 26, 2024 17:59
Dananji
force-pushed
the
refine-content-search
branch
from
June 26, 2024 18:00
d2a7178 to
5827fd3
Compare
…t search factory for matching
Dananji
force-pushed
the
refine-content-search
branch
from
June 26, 2024 18:08
5827fd3 to
3e24639
Compare
Dananji
marked this pull request as ready for review
June 26, 2024 18:08
4 tasks
Dananji
marked this pull request as draft
June 27, 2024 13:02
…bal matching for JS search
Dananji
force-pushed
the
refine-content-search
branch
from
June 27, 2024 14:22
08ae4d3 to
0eb40ec
Compare
Dananji
marked this pull request as ready for review
June 27, 2024 14:22
masaball
approved these changes
Jun 27, 2024
masaball
left a comment
masaball
left a comment
Contributor
There was a problem hiding this comment.
As far as I can tell this looks good.
Co-authored-by: Mason Ballengee <[email protected]>
Dananji
force-pushed
the
refine-content-search
branch
from
June 27, 2024 15:51
5a1a27f to
0a96e1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refinements to feature added in #502
This PR includes the following refinements to content search: