Update Node in Circle-CI - #506
Merged
Merged
Conversation
Dananji
force-pushed
the
update-node-circleci
branch
from
May 23, 2024 18:16
1e62a57 to
3db06a3
Compare
This was referenced May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that both node version in Ramp's CircleCI orb are EOL, when came across the failing tests in #505.
So, this PR is to uppgrade Node in Circle-CI from node 14 and 16 to 18 (EOL: April 2025 according to https://endoflife.date/nodejs) and 20.
I first tried bumping up to Node 21, which failed because of
node-sassbeing deprecated.