Skip to content

Accessibility fixes to issues found in axe report - #493

Merged
Dananji merged 1 commit into
mainfrom
axe-a11y-fixes
May 10, 2024
Merged

Accessibility fixes to issues found in axe report#493
Dananji merged 1 commit into
mainfrom
axe-a11y-fixes

Conversation

@Dananji

@Dananji Dananji commented May 7, 2024

Copy link
Copy Markdown
Collaborator

Found these issues via a axe scan on Ramp demo site;

  • Ensures <dt> and <dd> elements are contained by a <dl>. Description list item does not have a <dl> parent element in MetadataDisplay component
  • Ensures elements with an ARIA role that require child roles contain them. Element has children which are not allowed: li[aria-label] in the StructuredNavigation component
  • Ensures every HTML document has a lang attribute. The element does not have a lang attribute in the demo implementation page

@cjcolvar cjcolvar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Dananji
Dananji merged commit 0a15d29 into main May 10, 2024
@Dananji
Dananji deleted the axe-a11y-fixes branch May 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants