Skip to content

Don't include 2nd bundled copy of css on demo page. Resolves #487 - #488

Merged
Dananji merged 2 commits into
samvera-labs:mainfrom
thirdwavellc:fix/duplicate-css
May 7, 2024
Merged

Don't include 2nd bundled copy of css on demo page. Resolves #487#488
Dananji merged 2 commits into
samvera-labs:mainfrom
thirdwavellc:fix/duplicate-css

Conversation

@patrick-lienau

Copy link
Copy Markdown
Collaborator

No description provided.

@Dananji Dananji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for the PR 🎉

Just one suggestion. It seems there are extra tab/space characters in the code. Would you please be able to re-format it?

@patrick-lienau

Copy link
Copy Markdown
Collaborator Author

No problem. It's now formatted with 2-space indents.

@Dananji Dananji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for re-formatting, looks great 🎉

@Dananji
Dananji merged commit 7e35da9 into samvera-labs:main May 7, 2024
@patrick-lienau
patrick-lienau deleted the fix/duplicate-css branch May 8, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants